Skip to content

[Release] Fix release wheels#1687

Merged
LeiWang1999 merged 2 commits intotile-ai:mainfrom
oraluben:fix-release-dist
Jan 18, 2026
Merged

[Release] Fix release wheels#1687
LeiWang1999 merged 2 commits intotile-ai:mainfrom
oraluben:fix-release-dist

Conversation

@oraluben
Copy link
Collaborator

@oraluben oraluben commented Jan 18, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Refined build/release workflow with unified release detection.
    • Distinguishes nightly vs. standard releases to control version labeling and Git-based versioning during wheel builds.
    • Ensures consistent version handling and labeling behavior across the wheel build process.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions
Copy link

github-actions bot commented Jan 18, 2026

👋 Hi! Thank you for contributing to the TileLang project.

Please remember to run pre-commit run --all-files in the root directory of the project to ensure your changes are properly linted and formatted. This will help ensure your contribution passes the format check.

We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 18, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

Consolidates release detection in .github/workflows/dist.yml by adding an IS_RELEASE flag and reorganizing logic that sets NO_VERSION_LABEL and NO_GIT_VERSION, with separate behavior for Nightly versus standard toolkit releases.

Changes

Cohort / File(s) Summary
GitHub Actions workflow
.github/workflows/dist.yml		 Adds IS_RELEASE env var; sets NO_VERSION_LABEL unconditionally to "OFF" in build wheels stage; replaces direct github.event_name == 'release' checks with IS_RELEASE-based logic and toggles NO_GIT_VERSION for Nightly-* toolkits vs NO_VERSION_LABEL for non-Nightly.

Sequence Diagram(s)

(omitted — changes are confined to a single CI workflow file and do not introduce multi-component runtime flows)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • XuehaiPan
  • LeiWang1999

Poem

🐰 I hopped through YAML, neat and spry,
Found flags that tell releases why,
Nightly whispers, labels say nay,
Standard ones parade the day,
CI carrots gleam — hip hop hooray!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title '[Release] Fix release wheels' directly addresses the main change—fixing release wheel build handling by refactoring version labeling and git version control logic.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@oraluben oraluben force-pushed the fix-release-dist branch 5 times, most recently from 83dd08f to bfa4627 Compare January 18, 2026 02:08
coderabbitai[bot]
coderabbitai bot reviewed Jan 18, 2026
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents 
In @.github/workflows/dist.yml:
- Around line 171-178: The conditional currently uses [[ ${{ env.IS_RELEASE }}
]] which treats the literal "false" as truthy; change the check to perform an
explicit string comparison against "true" (e.g., [[ "${{ env.IS_RELEASE }}" ==
"true" ]]) and keep the existing nested check on matrix.target.toolkit
(referencing matrix.target.toolkit) and the env writes to NO_GIT_VERSION and
NO_VERSION_LABEL so the branch only runs when IS_RELEASE is truly "true".

@LeiWang1999 LeiWang1999 merged commit 04f98c3 into tile-ai:main Jan 18, 2026
13 checks passed
@kurisu6912 kurisu6912 mentioned this pull request Feb 11, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@XuehaiPan XuehaiPan XuehaiPan approved these changes

@LeiWang1999 LeiWang1999 LeiWang1999 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oraluben @XuehaiPan @LeiWang1999